Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MAD Tank command bar deploy. #13700

Merged
merged 2 commits into from Jul 23, 2017
Merged

Fix MAD Tank command bar deploy. #13700

merged 2 commits into from Jul 23, 2017

Conversation

pchote
Copy link
Member

@pchote pchote commented Jul 22, 2017

Fixes #13698 and the missing tooltip description.

@pchote pchote added this to the Next Release milestone Jul 22, 2017
@obrakmann
Copy link
Contributor

👍

rob-v
rob-v approved these changes Jul 23, 2017
View reviewed changes
Copy link
Contributor

@rob-v rob-v left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

side note: it would be better to have as convention a OrderName constant in traits for cleaner code. E.g. MadTank uses "Detonate" string 4 times now.

obrakmann
obrakmann approved these changes Jul 23, 2017
View reviewed changes
Copy link
Contributor

@obrakmann obrakmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, need to approve properly. 👍

@obrakmann obrakmann merged commit 4c222e5 into OpenRA:bleed Jul 23, 2017
@obrakmann
Copy link
Contributor

Changelog

@pchote pchote deleted the fix-qtnk-commandbar branch October 15, 2017 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrakmann obrakmann obrakmann approved these changes

@rob-v rob-v rob-v approved these changes

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
Release 20171014
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchote @obrakmann @rob-v